From 5095780390924c597707d7744727d575eff1a9ba Mon Sep 17 00:00:00 2001
From: deathbybandaid <sam@deathbybandaid.net>
Date: Sat, 8 Jun 2019 10:41:52 -0400
Subject: [PATCH] better lock

---
 sopel_modules/SpiceBot/Database.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sopel_modules/SpiceBot/Database.py b/sopel_modules/SpiceBot/Database.py
index f1db2c6..8df5357 100644
--- a/sopel_modules/SpiceBot/Database.py
+++ b/sopel_modules/SpiceBot/Database.py
@@ -85,8 +85,8 @@ class SpiceDB(object):
         not already exist"""
         session = self.ssession()
         slug = nick.lower()
-        self.nick_id_lock.acquire()
         try:
+            self.nick_id_lock.acquire()
             nickname = session.query(Nicknames) \
                 .filter(Nicknames.slug == slug) \
                 .one_or_none()
@@ -107,11 +107,9 @@ class SpiceDB(object):
             self.nick_id_lock.release()
             return nickname.nick_id
         except SQLAlchemyError:
-            self.nick_id_lock.release()
             session.rollback()
             raise
         finally:
-            self.nick_id_lock.release()
             session.close()
 
     def set_nick_value(self, nick, key, value, namespace='default'):